Eric/CMCENDev
2
3
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: fully decode migration source images #88

Merged
bray merged 2 commits from fix/migration-corrupt-decode into main 2026-07-22 13:59:36 -04:00
Conversation 0 Commits 2 Files changed 4 +82 -9
Codex commented 2026-07-22 13:56:36 -04:00
Collaborator
Copy link

Problem

Sharp metadata inspection can succeed for a truncated PNG even though variant rendering later fails with a libpng read error.

Fix

  • fully decode every downloaded source image before uploading it
  • use the CDN jimmy crest fallback when pixel decoding fails
  • apply the behavior to retirement and Last Post imports
  • add a regression test using a PNG whose metadata is readable but pixel stream is corrupt

Verification

  • 9 unit tests passed
  • 3 OpenAPI contract tests passed
  • 22 Mongo integration tests passed
## Problem Sharp metadata inspection can succeed for a truncated PNG even though variant rendering later fails with a libpng read error. ## Fix - fully decode every downloaded source image before uploading it - use the CDN jimmy crest fallback when pixel decoding fails - apply the behavior to retirement and Last Post imports - add a regression test using a PNG whose metadata is readable but pixel stream is corrupt ## Verification - 9 unit tests passed - 3 OpenAPI contract tests passed - 22 Mongo integration tests passed
bray merged commit fcc905ff72 into main 2026-07-22 13:59:36 -04:00
bray deleted branch fix/migration-corrupt-decode 2026-07-22 13:59:37 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
bray
Eric
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Eric/CMCENDev!88
No description provided.